|
|
|
|
|
by bob1029
2289 days ago
|
|
I feel for text wrapping, letting it simply flow off the device screen works well in this UX scenario because all of these devices should be expected to be multi-touch enabled. It is very intuitive for a mobile device user to swipe left/right in order to scroll content that is obviously clipped by the screen dimensions. Swiping left/right and pinching to zoom are the very first things I tried when reviewing a PR. I feel if you could support some approach where the text item is displayed at full scale always (no line break/wrapping), and the user can basically treat the view like they would an image (pinch-to-zoom/pan). Additionally, perhaps the code review process on mobile could be somewhat different from the desktop experience. Instead of trying to display the full diff all at once for a file, perhaps you aggregate the diff regions, and then display those one-at-a-time. Sort of like a tinder for code reviews. Swipe left on a diff region for deeper review, swipe right for approval. Lots of cool stuff you can do if you fully-leverage the mobile device environment and related user knowledge. BTW, I love the direction all of this is headed in. Keep up the great work. |
|