Hacker News new | ask | show | jobs
by tastroder 2298 days ago
The license file does not seem changed https://github.com/Guake/guake/blob/master/COPYING but it did not contain his copyright notice in the first place.

They seem to have had an AUTHORS file in there that according to git blame was deleted in this commit 2 years ago, possibly by erroneously including AUTHORS in .gitinclude:

https://github.com/Guake/guake/commit/089d72aab3c1708ed3476e...

Before that he was included in the AUTHORS file as "- Gabriel Falcão <gabriel@guake-terminal.org>, 2007", his name still appears in a bunch of places in the code https://github.com/Guake/guake/search?q=Gabriel+Falc%C3%A3o&...

I'm not really sure how to find the diff that switched from explicit copyright headers in source files to "Guake authors", maybe that was just done as the default while the code was growing.

Couldn't really hurt to just include some attribution imho, not only for him but other contributors as well. It's kind of odd looking to me that one of the two original authors raised an issue on an active looking project and seemingly nobody even bothered to respond there.
2 comments
slavik81 2298 days ago
> I'm not really sure how to find the diff that switched from explicit copyright headers in source files to "Guake authors", maybe that was just done as the default while the code was growing.

I found it using git blame on an old file with that notice. The commit: https://github.com/Guake/guake/commit/86b1fa8a42b99cbbb75eee...

link
Anthony-G 2298 days ago
The git commit you linked would have required the committer to explicitly remove the `AUTHORS` file from the code-base. If a file is already being tracked, it won’t stop being tracked if a corresponding pattern is added to `.gitignore`. Removing the file in this way was most likely intentional and not erroneous.
link
Anthony-G 2298 days ago
From the most recent response to this issue, it seems that the file was removed with the intention that the list of authors could be programmatically generated: https://github.com/Guake/guake/issues/1703#issuecomment-5965...

I also see that Gabriel has now been credited in the project’s `README.rst`.

link