Hacker News new | ask | show | jobs
by fapjacks 2351 days ago
This sounds nice on the surface, good intent. But it smacks of inexperience and is the same mechanism that ends up pushing the kinds of dumb conventions that insist on golang's Trailing Comma. What is the expected outcome of your rule, and how do you expect additional, incremental bureaucracy to drive that outcome? Any time you push rules, you must expect that people will default to simply obeying the rule without questioning why the rule exists in the first place. This is just a natural cost-minimizing function of human beings. As a former console operator of a decades-old mainframe, let me warn you that this is how informal "operator manuals" end up spanning many three-ring binders filled with nonsensical, sometimes contradictory trivia, and how you end up with people going through the motions like some kind of ritual whose origins are lost in the mists of time.

If you're going to do something like this, I suggest that these kinds of "code quality gateways" aren't as absolute as OP recommends. Be smart about it: You could probably measure how "sloppy" a developer is (relative to some mean of their own output and not compared to the team or really anyone else). Simply bringing it to a developer's attention (programmatically) will do far more for your project's code quality than trying to dumbly enforce some list of code conventions about whitespace or whatever. Also, this is a kind of tool that should absolutely be scoped strictly on the level of the individual developer, with no possibility of having externally-visible reports generated from it, and absolutely not exposed to management. You don't want to give management too many knobs to turn, especially knobs like this.