Hacker News new | ask | show | jobs
by massung 2372 days ago
Interface looks nice!

From my perspective, though, the largest annoyance of PR reviewing is that diffs are alphabetical instead of conceptual.

For example, a large change ends up affecting 26 files named A, B, ... Z. The PR diff/review lists the changes starting with A and the last changes reviewed are in Z. But, conceptually, often it'll be that - if you made the PR - you'd rather the reviewer start with Z: the high level, this is why the PR was even needed, then jump to F: the data structure change enabling this, then off to B: initialization code that needed to account for the structure changes, etc, etc.

Currently, the only way around this - that I know of - is with the comments section and just noting for whoever reviews it what to look at in what order.

Having a tool that fixed that problem would be heaven to me.

1 comments

Huh interesting. I do agree that this is also a problem for me.

Would it follow naturally from just being able to see the files that are affected? I'll look at the model file first and then move onto the controller file for example.