|
|
|
|
|
|
by magduf
2383 days ago
|
|
|
>And I'm not sure why two people sign off changes instead of just one. Because more eyes catch more bugs. I work in a time like this where we have 2 or even 3 people review stuff; it's extremely common for one engineer to miss stuff that another one catches. It's particularly notable I think with junior vs. senior engineers: I think you really need at least one senior engineer reviewing everything before a merge, but you don't want to keep junior engineers out of the process because then they'll never learn. With trivial tickets, however, you can relax this rule and just have one person review before a merge. |
|
|
But for product inspection we have pretty good evidence, from millions of human hours of factory work, that it's a bit more complicated.
X makes a widget, and sends it for inspection by Y and Z. Y has a look, but assumes Z will catch anything that Y misses. But Z also assumes that Y will catch anything that Z misses.
You end up with two people doing a superficial inspection and missing problems.
Of course, that's only if they're doing the same inspection twice. If they have different and clearly defined inspection roles the two inspector problem doesn't apply.