|
|
|
|
|
|
by other_herbert
2383 days ago
|
|
|
One thing that I think would help (and would've helped the person's pr that I _just_ reviewed) is to look at the diffs that would be included, make sure the intentions / logic is clear... As an example from said pr, a new field was added named "other"... in this particular context this doesn't have any meaning at all.. I had to look into the sql changes to see what this data was then add the suspected real name as a suggestion in the code review... don't do things like that :D... So, all that to say, look at your diffs and do your own code review before you submit it.. make sure what you want to do is clear and makes sense... |
|
|