Hacker News new | ask | show | jobs
by taylodl 2383 days ago
"there were other times when my PR was outright rejected as it did not meet the required standards"

Are these standards published? If not then how are you expected to meet "required standards" that are not published? If so then why are you not reviewing your code yourself prior to the PR? Is training and/or mentorship provided for you to come up to speed with the required standards? Something seems off about this situation.
1 comments
Tade0 2383 days ago
This is more common than it may seem.

I've worked in at least two teams where there were those non-written "standards" which one learned only after a few lengthy code reviews.

Usually a sign of people trying to cargo-cult themselves to good code.

At least one time it was simply a case of gatekeeping so that other developers wouldn't threaten that person's position.

link
taylodl 2382 days ago
That's toxic. Especially when you're making junior developers feel they're not doing a good job because their PRs are being rejected for not adhering to not-published standards. Wow. I'd be looking for another job in a heartbeat. Life is too short to be working with people like that.
link