|
|
|
|
|
by lukey_q
2379 days ago
|
|
Without any further details I would suggest that this is entirely a communication issue and not one of code quality. "Good code" is not really something that can be defined, and learning general design patterns might help you in a general sense but I don't think it's going to fix this problem you're currently having. If your team is outright rejecting your PRs then knowing one other pattern or learning functional programming are not going to help you. Next time you're writing something of any significance, speak to the people on your team who will be reviewing the PR. If you aren't sure of how to design it, come up with a design collectively. If you do have an idea, ask them to approve it on a high-level before you write any code. The entire thing should be a collaboration, not you coding for however many days before finally exposing your code to your team in the form of a PR. This can be easier said than done, depending on how communication works at your company and on your team, but if your team and the people reviewing your code won't guide you a bit before and during your implementation of something then again I don't think knowing a couple more patterns is going to solve this problem. |
|