Hacker News new | ask | show | jobs
by tumetab1 2419 days ago
A clean online, and shared, environment seems like a better way to do PR reviews with the author than doing a Live Share.

Does the platform support that? Or wants to?

What I would like to stop a comment thread and jump to online-video-session to review some code. Live Share works but requires a stable environment by one of the parties which might be troublesome with some code.
1 comments
lostintangent 2419 days ago
The same team that builds Visual Studio Online also builds Live Share, and so we care very deeply about collaboration. That said, you can spin up a new environment for a PR and then start a Live Share session from there. This allows others on the team to jump in, and leave comments, entirely asynchronously, and without requiring a specific “host” to be online.

We have a lot more to do in order to make this scenario truly shine, but we’re very excited about the possibilities moving forward. I’d love to hear more about your specific thoughts on PR reviews, and what kind of workflow your team would find compelling.

link
tumetab1 2418 days ago
I think that matches perfectly what I have imagined. async and sync work support for PR reviews.

a) People not currently working on a repo (don't have a local build environment setup) and do tweaks and suggest improvements (e.g. add a unit test to prove make a bug clear) in a async way.

b) A tech lead/senior developer can request the author to join a live session to go explain the whole PR has a bad approach or misses a base guideline on the repo. Not sure on this case how a summary of review session should be added (maybe the PR should have a log of review sessions done).

c) A teach lead takes the PR has an opportunity to ask the whole team to join a review so that he can point out a recurring issues on the repo or to just align ideas on code quality.

link