[nullc]

There is a BIG difference between "always moves to the end of the function for error handling" use of goto, and general unstructured control flow goto.

The former isn't significantly different than exceptions, except that it's probably less likely than exceptions to cause unexpected errors because its more explicit.

At a very quick glance that's what the goto usage looks like in the codebase. This isn't to say that I think it's all appropriate, but if it was, I don't think your comment would have been any different.

There are a lot of really hot opinions on coding style and various fashions, but very little of it is backed up with research that connects it to defect rate.

I agree it would be good if sudo had an internal test suite (particularly system tests and fuzzing harnesses)-- but you also shouldn't discount the large amount of testing that goes on against it externally through both usage and external efforts.