Hacker News new | ask | show | jobs
by samuraiseoul 2437 days ago
Also don't just do what code review comments tell you to.

If you disagree, state that and tell them why. Maybe you know something they don't about why you did something the way you did. Maybe they are just wrong. Maybe there's some business requirement you know that they don't or vice versa.

Also the other bit of not making changes just because they tell you to is this, you need to understand why you're making the change. This way you won't make the mistake again and you'll learn. You may stop doing the thing again if they comment it enough times and you internalize it, but that's not understanding, that's pattern recognition and won't help you be a better dev.

Code reviews are a two way street and a great learning opportunity. Use them to your advantage! :D