|
|
|
|
|
|
by neighbour
2478 days ago
|
|
|
>There was another entire category of problem that I guess would be described as "I hate sets" and was mostly attributable to one former employee. These were recognizable immediately upon opening the code and were a nightmare. Care to elaboarate? I need a pick-me-up today. |
|
|
- Get a list of x in a table var
- while loop through x to build another list of y
- while loop through y and update z one row at a time
All of that rather than updating with a join.
Some of his other patterns were reusing variables for different things in a proc, using inefficient functions in a way that they executed once per row before the result set was really reduced much, nesting those functions, and using loops any chance he got.
You'd open up these slow, 500-700 line monster procs and have to figure out what they were doing and refactor them, but it was nearly illegible and there were no tests for them. Really a great reminder of what happens when code reviews aren't done.