[tetron]

On our team we review feature branches. When the developer thinks it is ready they have an assigned reviewer. The reviewer makes comments, the developer responds, and they go back and forth until it gets to LGTM. My general rule is that I need to understand what the branch is doing and why, so the review takes as long as it takes. If it takes too long that is often itself a sign that comments or documentation is needed.

For interns, they might not know when to ask for review, so you might need to check in on them once a day.

[jasonpeacock]

> If it takes too long

Or that the feature branch is too big (break it into smaller changes).

Or it wasn't well designed before coding started and now you're doing CR & design review.

Or you're arguing about style/best practices and your team needs to establish coding standards.

Or ...