|
|
|
|
|
|
by pizza_pleb
2517 days ago
|
|
|
Author here. Thanks for the feedback. > Developers should be responsible for their own QA. QA is not what code reviews are about. While I agree that each dev is responsible for their own QA and test should be run before opening a PR, two eyes are better than one. If checking the code out on local and testing doesn't take time and there is risk, then I'd say go for it. Catching changes earlier in a PR is less work overall than having to restart a large part of the process when QA catches them. Also see the link Smotko commented with [0], it also addresses your point. > if proposed change is complex or reviewer want to visually confirm this change, feel free to checkout this branch Yes, I specified that usability tests are usually reserved for PRs that introduce sufficient code changes and/or risk. [0]: https://blog.codereview.chat/2019/06/27/code-reviews-and-you... |
|
|