[arebours]

> Today he asked me 'explain this logic' (It was a simple timeout logic for angularjs, pretty obvious if you can google the keyword) but he was literally stuck on it for hours and then asked me to come and explain this logic and what is it doing.

Lately I started to review much more code than I write. And what I can tell you is that is very easy to fall into the trap of thinking that something is obvious when you spend a lot of time within specific domain, codebase, or technology. If someone can't immediately tell what some straight piece of code does it usually says the code could be simpler or more idiomatic rather then they are ignorant.

While I'm not necessarily saying something's wrong with your code I wouldn't assume he's in the wrong or that he's stupid.

Besides I think it's pretty normal to ask authors about their code when you work with it.

> I am a bit hesitant to work with him because I think he is not very competent and when he do not understands anything, he will simply complain to my manager that its my fault and my manager, being his friend, will listen to him.

Has it ever happened? Don't overthink it, just do your job and provide help to colleagues when needed.

[smileysteve]

> Lately I started to review much more code than I write. And what I can tell you is that is very easy to fall into the trap of thinking that something is obvious when you spend a lot of time within specific domain, codebase, or technology. If someone can't immediately tell what some straight piece of code does it usually says the code could be simpler or more idiomatic rather then they are ignorant.

I want to emphasize that this is senior level thinking.

Code needs to be able to be understood by not only the best and worst on your current team, but also for the engineers you hire in X years that may not ask the right questions to the correct people or when the people who wrote it are no longer there.