Hacker News new | ask | show | jobs
by makepanic 2635 days ago
If you found typos or issues with the docs, why not open a PR and fix it?

https://github.com/SpaceVim/SpaceVim/blob/master/docs/_posts...
2 comments
ahaferburg 2635 days ago
Because I'd have to fork, wait for the Github client to process the fork, find the source file that produced the error, fix it, commit, push, then go back to Github to create a PR. PRs are overkill for typos on a project I don't develop on.
link
arthurk 2635 days ago
You can do all of this from the web interface. There's a pencil icon on the top right of the document. It will let you edit the file then create a fork and PR
link
ahaferburg 2635 days ago
Awesome, didn't know that. Thanks!
link
beatgammit 2634 days ago
It's relatively new and fantastic for simple text edits, though I certainly would recommend actually testing changes if you're changing code.
link
krageon 2635 days ago
While you make a good point that pull requests can be made because it is open-source, I've always found the "pull requests welcome" response to a (presumably good faith) piece of constructive criticism as a little dismissive.
link
craftyguy 2635 days ago
Or, it literally means, "we don't know what you found, so please point it out."

Not every response for help is a "fork off."

link