|
|
|
|
|
by dhotson
5748 days ago
|
|
Looking pretty good. Nice one. :-) I can't claim much credit for the design of Kelpie, it's mostly a direct port of Ruby's Thin web server. I guess there's a couple of notes I'd make: - I'd recommend using the mongrel http parser rather than implementing your own. I wrote a PHP extension for it - http://github.com/dhotson/httpparser-php Also, some cosmetic stuff (feel free to ignore): - I prefer camelCase for methods - public/private access control on methods - PHP namespaces look and act weird to me so I don't use them - I prefer using underscores in names and a classloader to avoid require statements |
|