Calling something a "disgusting hack," isn't inherently insulting, it is just a description of how well self documenting and obvious its workings are, which in this case is not at all. Whereas calling something a "work of art" particularly from Linus is high praise.
And while there is some subjectivity to if something is a "hack" or not, the original author doesn't even seem to contend that too much. They were more interested in pointing out that this method likely works across compilers (since it relies on less undefined behaviour than it might first appear).
In any case, it is a neat trick, that I wouldn't want to run across in a codebase since I'd have to spend too long figuring it out.
I agree with you - I think I would take it as a compliment as well. Also, I take back my original post on what the best comment is in this post. This is better:
"this will break the minds of everybody who ever sees that expression"
I think it's the highest compliment I've ever seen Linus express to somebody. And he's not wrong, the hack is adorable. It would never have occurred to me that doing this was even possible in C.
I think in this life at least all that's left for Linus to enjoy are marvelously disgusting hacks. So with that understanding this is probably the ultimate compliment.
Calling something a "disgusting hack," isn't inherently insulting, it is just a description of how well self documenting and obvious its workings are, which in this case is not at all. Whereas calling something a "work of art" particularly from Linus is high praise.
And while there is some subjectivity to if something is a "hack" or not, the original author doesn't even seem to contend that too much. They were more interested in pointing out that this method likely works across compilers (since it relies on less undefined behaviour than it might first appear).
In any case, it is a neat trick, that I wouldn't want to run across in a codebase since I'd have to spend too long figuring it out.