Hacker News new | ask | show | jobs
by rococode 3002 days ago
I would be very hesitant to be the only person signing off on the PRs. Maybe if your company has multiple people approving PRs. If you have no other choice, just try to make it clear to your bosses that you dont actually know the language so you can't guarantee that your reviews will be as rigorous as they would be in Java.

In my experience, it might actually be harder to notice high-level than low-level, because code patterns are kind of tied to languages. Some of the theory stays the same like factories or whatever, but the language-specific things tend to vary a lot.

Take Java, for example. If someone uses an enum or a public static variable or static class with static variables or whatever, those are kind of design decisions that might arguably have a "right" answer to an experienced Java coder. But a newer Java coder probably wouldn't really be able to readily distinguish between use cases, only say that they are correct and somewhat neat code. It's much easier to catch weird syntax or bad style than to say "ok but you probably should restructure these couple of files" in a language you're not super familiar with.

Anyways I kinda rambled but the tl;dr is 1) let your bosses know (to the extent that you're comfortable with) that it's not your primary language, and 2) it's fine to learn as you go, just be aware that there's stuff to learn