|
|
|
|
|
by xtalx
3006 days ago
|
|
This is a really nice piece of work! I’ve been experimenting with building something similar for my employer... I like that theming isn’t really a concern here. It makes sense because Pinterest already has a “theme” and this implementation enforces the theme. I have a few questions... These aren’t framed as “defend the choices that were made because I think they’re dumb” kind of thing, haha. I just think knowing some of the reasoning behind some of the implementation details would be illuminating. Why not use something like Glam or Emotion to handle className generation? With absolute positioning on <Box />... is there a reason why the top, bottom, left, right props are limited to static values of and not like top={48} or left=“12px” Also curious on api that dictates Text component: color = css property color and Box component: color = css property background-color Does Pinterest not use textShadow? Curious why that’s not a part of the Text component. Text styling seems to be the most difficult part of a component based design system. Anyway this is great work! Hopefully I didn’t ask any stupid questions with obvious answers. Ha |
|