|
|
|
|
|
|
by tfjaeckel
3074 days ago
|
|
|
Thanks for adding more color to your original answer. I like you enforce the commit/ticket relationship. Is this purely an agreed process or do you use other measures to keep things consistent?
E.g. we typically add the ticket ref to each commit but at times that gets omitted. Also, I think that (internal) release tool is something crucial as the team grows. Will check shipit a bit further. Would you mind expanding a bit on the things you enforce for each of your releases? |
|
|
> I like you enforce the commit/ticket relationship. Is this purely an agreed process or do you use other measures to keep things consistent? E.g. we typically add the ticket ref to each commit but at times that gets omitted.
We're not enforcing it but we might in the future if the team grows and this gets out of hands. At the moment we're just reminding people that they should and it works great so far.
> Would you mind expanding a bit on the things you enforce for each of your releases?
It's still early but so far we check:
- it's not friday afternoon, we want to avoid as much as possible to have issues on the weekend
- it's not out of office hour - we're still all on the same time zone
- there's no lock (we can lock the release in case something goes wrong)
- there's no schema migration. If there is we remind you how to safely migrate schema and who to ping if you have a doubt (usually it should have been caught at the PR review)
- there's someone from the ops/core team around (connected on slack)
- that there's no translations missing for our main languages (french/english)
- + we do a few sanity checks like that our master staging is healthy (release means promoting our master staging)
edit: also I forgot but this is the shipit I'm talking about https://github.com/Shopify/shipit-engine