Hacker News new | ask | show | jobs
by taeric 3117 days ago
The point on commit messages is mind boggling to me. I have yet to join a team where I am not the first one that uses non single line commit messages.

It is even crazier when they do write some about their commit, but only in some stupid review tool where I then have to follow a bloody link to get to it from the commit itself. (I'm curious if some jerk thought referral links would help them know when reviews were useful later... Please let that remain the idle joke that it is, btw.)

I'm slowly getting folks to put more in the commit message, but leading by example is taking forever. :(

1 comments

I'm not sure to what extent this remains common, but certain git clients do or did encourage the user to stick to single-line commit messages.
Honestly, sometimes I'm fine with a single line passed to -m for the command. I don't have a hard rule that all commits must have an email attached to them.

However, unless the single line is "fix typo" or some such, often I'm very interested in why code has been sent up for review. And don't just tell me what you did, but why you did it. If I get one more "increased the retry policy" style messages that doesn't expand on why a downstream component needs us to retry more, I'm going to go insane.

A sister team of mine has gone so far as to templatize this. I'm very sympathetic to the idea, but I don't support it yet. I think I'm coming around, though.

I'm too used to seeing "updates" or "<JIRA_ID>". It's insanity. I wish we could get a common understanding let alone a template.