Hacker News new | ask | show | jobs
by tetraodonpuffer 3196 days ago
so you don't mind having review comments disappear if somebody updates the PR, and it doesn't bother you not being able to say in a comment "this needs fixing" in a way that you can mark it fixed later on (and without marking as fixed the PR can't be merged)?

Github reviews are fine for a one-and-done merge, but for a back & forth review I really wish it had the above...

2 comments

This looks like a good spot to plug Reviewable (https://reviewable.io), which addresses the disappearing / untracked comments issues and more, while still integrating with GitHub rather more gracefully than something like Gerrit. While GitHub's PR review tooling has improved in the last year there's still a fundamental difference in philosophy such that Reviewable isn't lacking for customers. :) (Disclosure: I'm the founder.)
I've looked at Reviewable several times, and I'm afraid to say I've never been convinced to try it. There's obviously a huge cost to moving team process over to a new tool like this, but also I just found it more difficult to understand what was going on compared to GitHub reviews, so it wasn't particularly compelling for us. Hope you don't mind the candid feedback!
Feedback is always appreciated, and candid feedback is highly prized! I get what you're saying, but it's a fine line to walk: if Reviewable is too much like GitHub, it won't be able to add sufficient value to be worth using. If it's radically different, few people will be able to figure it out at all. I'm happy with the balance I've hit but it's definitely not for everyone -- on either end of the scale! Also, there's a forthcoming migration from Angular to Vue where I intend to make major changes to the UX, which will hopefully increase usability and make onboarding easier... We'll see!
I totally agree, I wish it had that too!