| Scrypt isn't badly designd. It's also difficult to misuse. This is like saying "bcrypt is badly designed." Note that you are specifically attacking scrypt with the title -- "login.gov encryption" can be substituted with "scrypt." If you were to say it's illegal for them to be using scrypt since scrypt is not an approved KDF, that would carry more weight. Cryptographic flaws 1. scrypt is used as password-based KDF, which violates NIST 140-2 This isn't a cryptographic flaw! The phrase "cryptographic flaw" means something. 5. hash(E) is stored right next to the ciphertext from (4). Who thought that storing a hash of the encryption key right next to PII ciphertext encrypted with that key was a good idea? Storing the hash of an encryption key is fine, as long as the hash function is strong. It's frustrating that a government website is making solid cryptographic choices and then being lampooned like this. It would be far more productive to make scrypt an approved NIST KDF. |