Hacker News new | ask | show | jobs
by ruleabidinguser 3217 days ago
You're not evaluating them based on requirements you didn't share, are you? That seems a little unfair
2 comments

Not evaluating them; evaluating code.

Just handing someone an expanded version of "implement good error handling" is not likely to result in a good product. Every project has nuance and subtle trade-offs -- the code review is an opportunity to teach juniors how to map abstract design principles onto concrete implementations without falling back to "cookbook / cargo cult" programming.

I want them to take ownership of their own code, and advance down the path of craftsmanship because I believe this results in long-term value -- both to them personally and to the project at hand.

Is'nt that the point of an evaluation ?

"Hey, here is your test and here are the answers. You've got one hour" :)

Not really no