Hacker News new | ask | show | jobs
by hellwd 3216 days ago
I have tried a lot of times to enforce the code reviews because I have seen lot of bullshit being checked in to the source control but if you don't have support from other team members then even having the code review is waste of time. Code review should come from the gut feeling, you should be always self critical and let your code being evaluated by other people who care about software development in general and not by the people who just want to make their job done and to have something to mention during the stand up meeting. So depending on what kind of people you are surrounded with, you should decide is it worth to do it or not.

Code review is not a task or ticket, it should be more natural in all teams. Like it's normal to take a shower or brush your teeth, it's also normal to do code reviews and keep the code clean and good. But recently most of the teams are just skipping everything to make managers and owners happy. And they are always happy with beta, preview or even prototype - so sad.

Unit tests are something else. Good, clean and testable code starts from good and clean requirements that are easily understandable. From there you are able to write clear unit tests and imagine the whole story. If your manager or someone who is defining what needs to be done doesn't have the clear vision or plan then you have a good chance that your code will be bad - then unit tests are implicitly bad.