|
|
|
|
|
by kqr
3218 days ago
|
|
I'll provide contrast, then. Code checked into version control is never changed. What happens is the reviewer creates a derivative work. If they use my code as a basis for their derivative work, that's a sign of respect just as much as anything else. It means that they think I actually got it mostly right. The same argument applies if it's merged right away. Unless the reviewer(s) blatantly misunderstood something important, it's likely their fix is an improvement. And even if they did, the previous code is just a reset/rebase/oops-commit away. That said, you should still discuss the code to iron out misunderstandings and learn things. |
|