Hacker News new | ask | show | jobs
by bsimpson 3221 days ago
One interesting thought this article provoked:

Code review often catches typos, or edge cases that should be tested. As the OP points out, you end up serializing the problem into a comment, which the other developer has to deserialize, implement, and send back. Worse, these sort of issues often come across as nags - I'd be happy to fix a typo myself, but feel like a jerk calling someone else's out. I rather like the idea of pulling down somebody's diff, amending it, and pushing it back up. I'll have to try that sometime.

2 comments

You can’t catch all the issues in code review every time, and it’s not always you that does the reviews. If you fix everything yourself, the original committer won’t learn anything and the next submissions will have the same issues. Or perhaps the edge case isn’t really an edge case and there is nothing to fix after all, in which case you’ve wasted time for nothing.

Also, if you do this people will likely subconciously take advantage [1] of it in the long run, and if you ever leave the team quality will suffer.

[1] ever had flatmates? Do all the dishes and cleaning for a month and you’ll see :-/

You can also leave your review notes for non-trivial changes in the form of inline comments added directly to the changed files.