A bitcoin wallet is not top-secret material and I don't trust myself not to fuck up overwriting the entire disk. I'd rather just take an angle grinder to it and not worry about it.
For the everyday coins (which I never use), my phone. For the savings (which I don't have), hardware wallet. The Ledger Nano S is great, I have one, but the HW1 is also very good and very very cheap.
If your btc wallet is left unencrypted in your hard drive, either spinning or ssd, you have bigger problems than someone rummaging for your used hardware