Hacker News new | ask | show | jobs
by kandalf 3382 days ago
I think everyone on the team understands that helping unblock other engineers is as valuable as writing some code yourself. It generally hasn't been an issue getting timely review, though we have discussed tracking the average size of the PR queue as a metric if review times did worsen.

Most of the time other engineers on your team will review your code, but often engineers will pop across teams and doing code reviews if they have the time and the context. One change we've made is moving towards tagging a few engineers who might have the right context when you submit the PR.

Thanks for the tip about the title; will take a look!

1 comments

We've found mention bot to be helpful internally for intelligently selecting who should be performing reviews: https://github.com/facebook/mention-bot

Give it a try!

Hadn't seen this before, but looks pretty cool. Thanks!