| To be honest, the author of that blog post seems like he's kinda being a bit of a dick. > I submitted several lint cleanup pull requests. Getting each one accepted was a challenge. Primarily because the project owner isn’t really interested in having lint clean code. Having read through the PRs he filed[1], the "challenge" the author faced was to do with his needlessly changing things around to match Google style guide, which the project doesn't actually observe. (There's a lot of comments of the form "as a former Google employee, my shit doesn't stink" in there, as it happens.) In fact, most of them were merged straight away except his last one[2], where he'd changed existing code away from the project's preferred style, been asked not to, then threw a tanty and closed the issue. > for d in filter(os.path.isdir, path): This and the other example he gives are both from that last issue, which leads me to think this blog post was part of the aforementioned tanty. (It was published on the same day, too.) Let's be honest, if the worst issue you can find with a codebase is that it uses filter() instead of a generator expression, it's probably a pretty good codebase. > All you have to do is Google “python map filter deprecated”. Yes, do, and you'll find they aren't. The BDFL doesn't like them, but that's not the same thing. > I noticed that the directions for running the unit tests did not test the code in my local git repository — it tested the code installed by pip. ... Anthony told me he wrote the directions to specifically test the installed code, not the code in his git repository and he didn’t understand why anyone would test their uncommitted code. I can't find the issue where he raises this, or where the maintainer says that. Perhaps the author isn't familiar with `pip install -e`? All of the other issues in that first 'P.S.' paragraph appear to be fixed, some by him even. tl;dr This doesn't seem like a damning criticism of fundamental project management issues so much as a tantrum being thrown by someone because they couldn't walk in to a project and impose their stylistic preferences on everyone else. [1]: https://github.com/xonsh/xonsh/search?utf8=%E2%9C%93&q=is%3A...
[2]: https://github.com/xonsh/xonsh/pull/512 |