Hacker News new | ask | show | jobs
by abronan 3451 days ago
I definitely don't get stressed when people are pointing out errors in my code. It's a sign that you can trust your coworkers. As some people mentioned already, I become stressed when people just approve a big and complex change without any question/comment because this is likely that they are busy and that they didn't try to understand it. This is how you get bugs slipping into production environment.

Unnecessary nitpicks that are holding Pull Requests for days/weeks are stressful though. Because they are holding a feature hostage to satisfy the ego of the commenter on an opinion that is subjective. It is especially unnerving when the commenter is dropping the nitpick and then disappears and never comments on the PR again, or only after months. I appreciate when the commenter clearly points out that this could be an optional change to slightly improve the code (or by opening a separate issue after merging).