[gkop]

Has GitHub improved reviews since launch? I tried the review feature at launch and found it to be a severe regression from plain PR inline comments, because the review comments weren't hidden when the code they referenced changed, so I had to manually check each review comment to see whether or not it was addressed by a follow-on commit. I emailed their support asking if I was using the review feature wrong, and they said No, I was using it correctly, and it was a known weakness in the feature that they were tracking.

Review requests are useless until GitHub makes the reviews themselves useful.

[piotrkaminski]

Heh, I never cease to wonder at the variety of -- often contradictory -- code review workflows. For me and many others automatically disappearing comments are a misfeature, since we _want_ to verify that a comment was correctly addressed. To each their own... :)

[gkop]

At the launch of GitHub reviews, it's not just that the outdated comments weren't hidden, but at that time, there were no tools in place of that to collapse threads, mark sections of diff as approved, or otherwise resolve comments with follow-on pushes. That's why I asked their support if I was using it correctly, I was super confused. I'm definitely interested in a better GitHub workflow.

[deeplyoptional]

Yes, outdated comments are hidden again.

[gkop]

Thanks! I look forward to taking reviews for another test drive soon.