Hacker News new | ask | show | jobs
by mbrt 3480 days ago
blog author here. Thanks for your feedback, I appreciate that! I'm gonna edit the post with it. And don't worry about your code... it's the best crate I've seen so far ;)

By the way, shouldn't msys_tty_on_handle be marked 'unsafe' too? I'm wondering if what happens I pass in some garbage as a handle...
1 comments
burntsushi 3480 days ago
> By the way, shouldn't msys_tty_on_handle be marked 'unsafe' too? I'm wondering if what happens I pass in some garbage as a handle...

Possibly. How would you construct said garbage? Would it require unsafe?

link
mbrt 3480 days ago
I'm not sure, probably yes. It all depends on the winapi crate. If you can get an handle of a different "type" than the expected one, then it's garbage for GetFileInformationByHandleEx. Probably you can't do it without unsafe, so maybe it's fine.
link