Hacker News new | ask | show | jobs
by dri_ft 3496 days ago
I slightly prefer the 'worse' solution for the second problem, at least in terms of substance, not necessarily style. The trick the 'improved' version does with uniq seems a little hacky to me, somehow.

The first problem has a clear improvement.

I just checked ruby doc and 'reduce' and 'inject' seem to be synonyms, as far as I can tell.

1 comments

I've never done Ruby, but what I don't like about that second solution is how much logic it puts into formatting directives in a string literal:

> "#{x}#{input.split('').count(x)}"

Just because Ruby apparently allows you to do that much in a formatting directive doesn't mean you should.

Assuming this is a variant of RLE-style compression, the implementation is also wrong, if the input is `aabbcccddaa`, it will return "a4b2c3d2" instead of "a2b2cc3d2a2".