Hacker News new | ask | show | jobs
by jglovier 3570 days ago
Great idea. Thanks!
1 comments

While I have your attention. A few thoughts on code reviews. It's be nice if 1) approvals somehow show up on the pull requests index page, 2) create a notification within GH, 3) send an email. Right now you have to go to the PR page itself to see approvals.

Edit: I saw an approval email notification on one PR, but not another.

Thanks!

+1 for seeing approvals visually on the pull request index page. I currently use a "Reviewed" label with my team, and unfortunately we still have to even with this feature.
All reviews definitely generate notifications.

We definitely want to get some way to surface reviews better across all PR's and/or projects. I've been bothered by that myself while we were building this. :)