Hacker News new | ask | show | jobs
by btilly 3700 days ago
It has become popular, but it is still wrong. If you're a nested dependency, then DON'T require end developers to be aware that you're there. Doing so makes you a leaky abstraction.

http://www.joelonsoftware.com/articles/LeakyAbstractions.htm...

Though the author does have a point that fault here could be put on the library that added the dependency without a default logging behavior. However I'd still blame SLF4J for making the default case suboptimal.

1 comments

But it seems useful because you can decide what behavior your want for your project.
Right, it is configurable.

But there is no reason why a configurable library can't have reasonable default behavior if no configuration is supplied. While still being configurable. If you're winding up as a buried dependency that end developers may not be aware of or care about, you want to do this.

What reasonable default behaviour? If you're writing a console application, dumping to stderr is probably not a good idea - writing random log files that the end-user/admin has no idea about is probably not a good idea - shutting up and doing nothing is probably not a good idea (Java code has a tendency to use logging to warn about non-fatal configuration errors, etc). And let's not get started on what verbosity to set by default.
A good default is to write to STDERR if the severity level is above some threshold, otherwise do nothing.

That way the console can tell you about configuration errors, and by default the library will log nothing. If the library author considers it important to log somewhere, the library author is responsible for putting both an understandable warning up, and writing documentation.

If you are creating a library? You shouldn't log at all. Return errors or throw them - do not log.

If you are creating a console application? Stderr is the standard way to log errors. Let the user decide if where it points to.

If you are creating a daemon, set the log destiny at the launch script. The application can either log to stderr anyway and let the script handle everything, or offer a parameter for setting the log channel.

The Java community fixation on logging is really not deserved. It's more caused by bad error handling by their main web servers than by any fundamental problem.

Logging is useful for more than just error conditions; how does that square with your advice to library authors?
If it's not an error condition, you return it.

Libraries must not do any covert IO (in fact, any covert anything). A logging library is the only one that should log, and not their own messages.

They may write into some main application supplied collector, if it is not global, or if it is clearly handled as a message passing API.

The Java way is simply bad.

True enough. I guess the main downside would be including a library that may never be used.