|
|
|
|
|
by computmaxer
3711 days ago
|
|
As someone who works at Workiva, I completely agree. The post comes off a little more abrasive than I'd like. I think writing it as an "email" to a hypothetical new team member makes it worse. The point is: we take our code reviews seriously and we may point out things that seem silly or nitpicky, we may question your approach, we may make many suggestions for improvement, but at the end of the day it is nothing personal. It is for the common goal of high code quality. |
|
I try not to ask arbitrary comp-sci questions, but instead provide the candidate with a block of code and ask them to provide a comprehensive code review (usually through a github pr).
Afterwards I perform a my review, and highlight any differences in style or methodologies. I'm not really looking for people that have the exact same outlook as me, I'm just looking for people that have some kind of standard they adhere to.