fyi for you and other commenters, there is no need to do this anymore - you can have separate accounts and create an iCloud Family instead, purchases + payment info get shared and nothing else.
That doesn't work if the other person uses an AppStore in a different country.
You can add the other person to the 'Family' but you can not share purchases. (Very annoying...)