Y
Hacker News
new
|
ask
|
show
|
jobs
by
desireco42
3731 days ago
What I got from this article is idea to squash every pull req into a single commit. I think this is valuable idea.
3 comments
xori
3731 days ago
I agree, which github now does for you
https://github.com/blog/2141-squash-your-commits
link
desireco42
3731 days ago
thank you for pointing this out for me
link
cyphar
3730 days ago
As someone who does a lot of git bisecting, this is a horrible idea. Only do it on a case-by-case basis. If it takes 5 commits to make 5 complete changes that implement something, keep them as 5 commits.
link
ionforce
3731 days ago
It's such a naive idea to apply this to every PR unilaterally.
link
https://github.com/blog/2141-squash-your-commits