|
|
|
|
|
by akeating
3733 days ago
|
|
I find that timely feedback is essential to the pr process working effectively. A few things can help:
* submit RFC prs that are not intended to be merged early so architectural or design issues can be socialized early
* break your commits into logical chunks
* open an epic branch and merge smaller commits into it. When ready, open a new pr to merge the epic into master. This does sound like a culture issue. Everyone should be empowered in this process and everyone needs to be involved. I think of it a check-and-balance, but we all have a responsibility to complete features to a high standard, in a timely manner. If a feature is delayed because reviews are slow, we're all responsible. |
|