| > Its something we're still working on, but it still helps to vocalize your support for wanting improved force push support. :D YES! I wish for that feature everyday. Gerrit does it exactly right. Related to this, I really, really hope that you will consider displaying commits
in a PR in the correct order, suppose that I have three commits on top
of master: a->b->c->master
If I git rebase -i master and reorder my commits so that they look like this: c->a->b->master
Then the commit list in the PR will still be displayed in chronological order
instead of DAG order, this is very confusing! The only workaround I've found is
to amend every commit in my PR so that the timestamp order match the DAG order,
this isn't very fun to do.By the way, the post explicitly says: > Some teams choose to use a commit-by-commit workflow where each commit is treated as the unit of change and is isolated for review. I'm glad that you're acknowledging that. But then why do comments on commits
still get hidden when they correspond to an outdated diff? I would love to be
able to comment on individual commits, but if half my comments are hidden
because they correspond to lines that don't match the current diff, then I'm not
going to do it for fear of my comments being missed. You should not hide
important information that I'm trying to communicate!
Here's a better way to do it: Add a "Done" button like Rietveld/Gerrit for every
comment (this is a very useful feature on its own) and hide comments _if and
only if_ the "Done" button has been clicked. Anyway, I'm glad that people are working on this stuff and that they're
listening to the community, thank you! |