Hacker News new | ask | show | jobs
by GolfyMcG 3755 days ago
A practice we've implemented to manage this is tagging pull requests that have anything over 250 added (green) lines of code. Before anyone is willing to give you a code review, you have to justify why such a pull request requires so many lines, break it into multiple pull requests, or refactor your code. Often times, it makes review easier because the PR's are smaller and enforces a simple baseline that tells the programmer, your code is too big!
1 comments

Maybe all diff views should show added lines in red and removed lines in green. If anything, it would help create awareness of the need for more compact systems.