|
|
|
|
|
by chx
3767 days ago
|
|
https://www.drupal.org/node/1874530 everything in this (short) issue is a lie: submitted as "Proudly Found Elsewhere" when a significant portion of the code was written by the author of this issue, just submitted upstream and then pulled downstream (check @author tags, it's right there but https://github.com/symfony-cmf/Routing/commits/master?page=9 also here for the sake of archives, commits start at 3b152c4) to avoid usual scrunity by downstream (ie the normal Drupal core review process). To avoid anyone catching this (and I haven't caught it for a very long time) it was submitted on Dec 26 when everyone is obviously away. "I don't believe CMF is as stable as Symfony core" this is at best FUD, Symfony CMF won't see a stable release for another ten months http://symfony.com/blog/the-symfony-cmf-released-its-first-s... Symfony 2 core had several stable releases http://symfony.com/blog/symfony-2-1-3-released by this point. I have no idea how the core committers didn't catch all this -- but you can't really blame them, there was a gigantic pressure to move ahead. And then based on this foundation, everything link related, inbound and outbound was converted to route names instead of paths which is a) absolutely unnecessary b) destroys performance. Of course, there was history and reason trying to avoid review of this pile of code. Symfony, in general, is an extremely poor fit for Drupal: Drupal was a convention based system and Symfony is very heavily a config based system. The most obvious and very glarring misfit is hooks vs events and despite hooks being the central Drupal building block there never was a fundamental, through research as to what if anything to replace them with. Compare the scrutiny Symfony Foundation received in https://groups.drupal.org/node/167299 to how Symfony HTTP Kernel got added: via an admittedly "off-the-cuff" prototype https://groups.drupal.org/node/198538 . Note that I was trying to push back on this immediately with little success then or ever. So after shoehorning HTTP Kernel in over some bitterness and fighting it stands to reason the architect wants to avoid any scrutiny this pile of code would receive. Ps. Events have so much overhead that by now Drupal only uses the interface for them as we rewrote the dispatcher to scale. Benchmarks at https://www.drupal.org/node/1972300#comment-9216069 . |
|