[scaryclam]

> Getting your changes into a project that relies on patches is trivial; you just send them the patch

But only if you're used to creating patches. New developers are more likely to know how to create a quick PR than they are to know about creating and submitting patches. I'm not a Python developer either but I know this was one of the considerations after reading the mailing list thread.

It was also addressed in the discussion that developers who prefer to submit patches should still be able to do so, just as they are now. To me, this is the best of both worlds and removes the whole "walled garden" thing.

Github also provides a well documented API and there are multiple services that already plug into it. If they removed that then yes, I would have an issue with the development staying on github. As it stands right now, there's no reason github specific information can't be linked up to external systems, or even integrated with them nicely.

[carussell]

Take somebody who has never done a pull request (GitHub-style, not Git style) and has also never created a patch, and then try to teach them how to do both. Which is easier? Creating a patch will win every time.

[saurik]

Yeah. And the same is actually true for teaching a college student who has ssh/web access to their university file server how to make a distributed git repository setup with real "pull requests" (where I tell you my URL and a branch) vs. teaching someone how to make an account on GitHub and use their web interface to make a repository and then use their pull request user interface to get data between forks. I know this as I teach lectures on git, and it is seriously two console commands on your server to set up a fully working git setup in the way git was designed to be used.

GitHub has managed to cause a culture around git that there exist problems that don't exist that they can solve, and then their solutions are one-off specific solutions that only work so well if you are willing to use all their other features and you get all your developers and users to use the service as well. You are correct that GitHub is every bit as much a walled garden as Facebook.

[chishaku]

We're talking about Python core development. I just can't see the minor nuances of GitHub-style pull requests being a significant barrier to entry for new contributors.

It seems the familiarity of GitHub was actually a primary selling point.

> There were multiple reasons as to why I made that decision. One was that GitHub has basically built a social network of open source contributors. That led to various core developers telling me that they were comfortable with GitHub already and they were hoping it would win.

> Lastly, our BDFL prefers GitHub. Since the beginning of this whole decision process, Guido let it be known that he thought GitHub was the best choice.

[jguegant]

I have no clue on how to generate a patch. But I did a fair amount of pull requests... It might be a generation problem.

[snuxoll]

git format-patch --to=[e-mail] HEAD^ - send the generated email, done.