Suicides definitely decrease with less access to guns, however many countries with gun restrictions have higher rates of suicide than the US (e.g Japan, S Korea, France, Belgium) [1]
Also suicides via firearm had been declining in Australia prior to any buyback. [2]
