Hacker News new | ask | show | jobs
by joeconway 3890 days ago
Can we expect to see more focus on improving merge requests within Gitlab? I've felt as though for the longest time it's not had any of the major functionality gaps filled and seems to be deteriorating with each release. I'm wondering now if Gitlab doesn't see it very high on the list of priorities for the product

(Apologies if this comes across as overly negative, I use Gitlab all day every day and it's a great tool)
1 comments
jobvandervoort 3890 days ago
Absolutely. Code review is at the core of the product and it should be amazing to use.

Coming up we will add the ability to revert merges [0]. We're also working on redoing the UI of MRs (and much of the rest of the app) and have someone working fulltime on performance now, which will also help here.

What would you like to see improved? Very curious to hear.

[0]: https://about.gitlab.com/direction/

link
joeconway 3890 days ago
That's great to hear! Specifically, the lack of syntax highlighting on merge reviews is a killer feature. My team actually temporarily moved over to Phabricator, specifically for this feature.

- Currently the only way for someone to indicate that a merge request is good to merge is by contacting them outside of Gitlab or doing the upvote on the MR, which fascinatingly is only possible by commenting with a :+1: thumbs up

- Also multiple assignees on MRs

- Ability for anyone to add labels to an MR, not just the assignee

- On the index page listing MR's I've often felt like a solid improvement would be to show both author and assignee. I think Gitlab has alternated between one or the other a few times on this page but both seem to me to be pertinent information.

link
jobvandervoort 3890 days ago
> the lack of syntax highlighting on merge reviews is a killer feature

Creating an issue for this and scheduling it. I agree we need this for diffs => issue here: https://gitlab.com/gitlab-org/gitlab-ce/issues/3292

> Also multiple assignees on MRs

We solved this with the 'approvers' feature. We still want to only have a single assignee, as only a single person can click 'merge'.

> Ability for anyone to add labels to an MR, not just the assignee

This should be anyone with editing rights to the MR, such as masters. We're improving the UX to make this easier in GitLab 8.2 or 8.3 (also creating labels on the fly and quickly adding more).

> On the index page listing MR's I've often felt like a solid improvement would be to show both author and assignee. I think Gitlab has alternated between one or the other a few times on this page but both seem to me to be pertinent information.

Currently both are shown: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests

One is inline, the other as icon. Let me know how you think we can further improve this.

link