Hacker News new | ask | show | jobs
by erydo 3892 days ago
He identified a bug in the function `evaluateIntegerExpression` which parses an integer literal from LLDB, erroneously always parsing in base-16.

But the pull request he created (https://github.com/facebook/chisel/pull/117) didn't fix that; instead it just replaced that function call with manually parsing the literal in the one specific place he was having problems with.

Did I miss something there? That seems like a really weird "solution". Why not just fix the original function?

1 comments

You're right. I put in another pull request to fix the original function, but that's not yet been accepted. https://github.com/facebook/chisel/pull/122
Ah, cool, I hadn't seen that. Good work and I liked your post!