Hacker News new | ask | show | jobs
by xahlee 3931 days ago
hi PuercoPop, that code is meant to be run as a script (emacs --script filename), so i used setq is possibly more proper. But, this is just post-fact defense, as lots my pages began as quick blogs. As you know, CL has controversial status in gnu emacs dev community. e.g. http://ergoemacs.org/emacs/elisp_common_lisp_in_emacs.html I myself avoid it, because i don't like CL. I'm going to tuck in the hanging parens in a few days. Thank you for the criticism. (thanks to many others here too)
1 comments

But stuff like

   (let (var1 (var2 0))
     (when condition
       (setq var1 (var1-initializer-form))
        ...)))
is just silly. Only the inner scope of the when uses var1, or any of the vars; it could just be:

   (when condition
     (let ((var1 (var1-initializer-form))
           (var2 0))
        ...))
Never do two-step initialization of a variable without an excellent reason; it's just sloppy otherwise.