Hacker News new | ask | show | jobs
by epmatsw 3942 days ago
Bummer. Doesn't compile with iojs.
2 comments

It looks like it uses "child_pty" to spawn pty's. child_pty hasn't been updated to support the latest nan/v8 api (in fact, it looks like it's been unmaintained since March). It also improperly uses fs streams to read and write to the pty fd which will exhaust the thread pool very quickly. So, even if you can compile it, it will still break.

It also looks like it doesn't handle sigchld with a waitpid anywhere, so be prepared to have a zombie apocalypse on your machine.

I'd recommend the author switch to pty.js[1] which now compiles on io.js >=3.0.0 and reads pty fd's properly, but I'm biased.

[1] https://github.com/chjj/pty.js

Thank you for the advice. Pty.js was my initial choice, but it didn't support return codes at the moment. I'll take a look at it again.
Add an issue for it.
Try the 'n' module/cli.